linux-mips
[Top] [All Lists]

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

To: Marc St-Jean <stjeanma@pmc-sierra.com>
Subject: Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver
From: Alan Stern <stern@rowland.harvard.edu>
Date: Tue, 5 Jun 2007 17:12:35 -0400 (EDT)
Cc: gregkh@suse.de, <linux-mips@linux-mips.org>, <akpm@linux-foundation.org>, <linux-usb-devel@lists.sourceforge.net>
In-reply-to: <200706042323.l54NNi6e013258@pasqua.pmc-sierra.bc.ca>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Mon, 4 Jun 2007, Marc St-Jean wrote:

> [PATCH 11/12] drivers: PMC MSP71xx USB driver
> 
> Patch to add an USB driver for the PMC-Sierra MSP71xx devices.
> 
> Patches 1 through 10 were posted to linux-mips@linux-mips.org as well
> as other sub-system lists/maintainers as appropriate. This patch has
> some dependencies on the first few patches in the set. If you would
> like to receive these or the entire set, please email me.

My personal impressions:

This does far too much to be a single patch.  It needs to be broken up.

The change to hub.c looks more complicated than necessary.  You ought 
to be able to share more of the code.  Turning off power to the 
overcurrent port would probably be okay for any hub.

The changes to file_storage.c and other gadget drivers look completely 
unnecessary.  You're apparently trying to disallow 0-length transfers 
on endpoint 0.  For one thing, that's liable to break some protocols.  
For another, it would be better to make the test at one place, in your 
controller driver, instead of spread out among multiple gadget drivers.

Alan Stern


<Prev in Thread] Current Thread [Next in Thread>