[Top] [All Lists]

Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}

To: Ralf Baechle <>
Subject: Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}
From: Sergei Shtylyov <>
Date: Mon, 04 Jun 2007 19:15:53 +0400
Cc: Atsushi Nemoto <>,
In-reply-to: <>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803

Ralf Baechle wrote:

Unify lib-{32,64}/watch.S into lib/watch.S and remove lib-{32,64}

The old 64-bit __watch_set() expected an physical address and the old
32-bit __watch_set() expected a KSEG0 virtual address.  The new
unified __watch_set() is based on the 64-bit one.  Since there is no
real user of the __watch_set(), this incompatibility would not cause
any problem.

I think we can simply drop the entire watchpoint support.  This was
only ever working on R4000/R4400 and even there only somewhat useful
for kernel debugging.  So if we ever use watchpoint support I think
something needs to be developed from scratch.

   Watchpoints *could* be supported as part of KGDB, BTW.


WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>