linux-mips
[Top] [All Lists]

Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Mon, 04 Jun 2007 19:15:53 +0400
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
In-reply-to: <20070604151048.GA30128@linux-mips.org>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070605.000239.31638706.anemo@mba.ocn.ne.jp> <20070604151048.GA30128@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Ralf Baechle wrote:

Unify lib-{32,64}/watch.S into lib/watch.S and remove lib-{32,64}
completely.

The old 64-bit __watch_set() expected an physical address and the old
32-bit __watch_set() expected a KSEG0 virtual address.  The new
unified __watch_set() is based on the 64-bit one.  Since there is no
real user of the __watch_set(), this incompatibility would not cause
any problem.

I think we can simply drop the entire watchpoint support.  This was
only ever working on R4000/R4400 and even there only somewhat useful
for kernel debugging.  So if we ever use watchpoint support I think
something needs to be developed from scratch.

   Watchpoints *could* be supported as part of KGDB, BTW.

  Ralf

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>