linux-mips
[Top] [All Lists]

Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] Unify watch.S and remove arch/mips/lib-{32,64}
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 4 Jun 2007 16:10:48 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20070605.000239.31638706.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070605.000239.31638706.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Jun 05, 2007 at 12:02:39AM +0900, Atsushi Nemoto wrote:

> Unify lib-{32,64}/watch.S into lib/watch.S and remove lib-{32,64}
> completely.
> 
> The old 64-bit __watch_set() expected an physical address and the old
> 32-bit __watch_set() expected a KSEG0 virtual address.  The new
> unified __watch_set() is based on the 64-bit one.  Since there is no
> real user of the __watch_set(), this incompatibility would not cause
> any problem.

I think we can simply drop the entire watchpoint support.  This was
only ever working on R4000/R4400 and even there only somewhat useful
for kernel debugging.  So if we ever use watchpoint support I think
something needs to be developed from scratch.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>