linux-mips
[Top] [All Lists]

Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [MIPS] Fix modpost warnings by making start_secondary __cpuinit
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 1 Jun 2007 18:40:21 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20070602.013022.52128810.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <S28573756AbXEaP7t/20070531155949Z+115@ftp.linux-mips.org> <20070602.013022.52128810.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.3i
On Sat, Jun 02, 2007 at 01:30:22AM +0900, Atsushi Nemoto wrote:

> Looking at arch/mips/kernel/smp.c, I suppose there should be much more
> functions to be marked as __cpuinit.  For example,
> prom_init_secondary(), prom_smp_finish(), prom_smp_finish(),
> prom_boot_secondary(), etc.
> 
> And then, smtc_init_secondary(), smtc_smp_finish(), etc. ...

That is absolutely correct but beyond the minimal fix needed to deal with
the warning for 2.6.22.  Longer term I'd like to get CPU hotplugging
working, it could be a handy feature with multi-threaded kernel models such
as VSMP and SMTC.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>