linux-mips
[Top] [All Lists]

Re: SMTC Patch

To: "Kevin D. Kissell" <kevink@mips.com>
Subject: Re: SMTC Patch
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 31 May 2007 17:13:04 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <465C2DD8.6090208@mips.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <465C2DD8.6090208@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Tue, May 29, 2007 at 03:42:48PM +0200, Kevin D. Kissell wrote:

> The attached patch fixes some problems with the linux-mips.org
> 2.6.21 kernel for SMTC kernels for the Malta platform.
> 
> The fix to smtc.c just eliminates a warning that crept in.
> 
> The fixes to traps.c eliminate a hypothetical problem with
> out-of-bounds arguments (which were being reported, but acted
> upon anyway, which was somewhat insane)

set_vi_srs_handler is a void function, so currently can't return an
error either and not scribbling around isn't really a solution either
because no matter waht, for a vector number >= 8 won't work right.
So I went for a more drastic solution using BUG_ON().

> and a real one with
> PageMask going uninitialized in VPE 1 on any MIPS MT processor
> that doesn't reset PageMask to a sane value, which the archtecture
> does not require.
> 
> The restoration of the #define in mips-boards/generic/time.c
> is necessary to make the Malta SMTC kernel build.  If whoever
> deleted it has a good reason for it not to be done the way it's
> done, that's OK, but *some* definition must be provided.

I really don't see why we should fix code that writes r/o bits in a
failed attempt to do something that already happens elsewhere, so I
applied the patch which Chris sent in private.

Btw, your patch was dealing with four separate issues.  Would be kind of
handy if something like that would be submitted as four separate patches.

  Ralf

PS: A Signed-off-by: line please!

<Prev in Thread] Current Thread [Next in Thread>
  • SMTC Patch, Kevin D. Kissell
    • Re: SMTC Patch, Ralf Baechle <=