Re: [PATCH] zs: Move to the serial subsystem

[Andy Whitcroft <apw@shadowen.org>]

Andrew Morton wrote:
> On Tue, 29 May 2007 14:03:54 +0100 (BST) "Maciej W. Rozycki" 
> <macro@linux-mips.org> wrote:

> Hey, you have volatiles and checkpatch.pl didn't complain.  Andy, a
> reference to Documentation/volatile-considered-harmful.txt would suit.
> 
> (That's
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/broken-out/volatile-considered-harmful-take-3.patch)

Added ...

Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
PATCH: XXX.eml:374:
FILE: linux-2.6.22-rc2/drivers/serial/zs.c:131:
+       volatile void __iomem *control = zport->port.membase +

[...]

I will batch up any changes to checkpatch.pl and send you them as a blob
when they get "interesting" if that suits.

-apw