linux-mips
[Top] [All Lists]

Re: [PATCH] zs: Move to the serial subsystem

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zs: Move to the serial subsystem
From: Andy Whitcroft <apw@shadowen.org>
Date: Wed, 30 May 2007 10:54:59 +0100
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
In-reply-to: <20070530011224.bf36d2df.akpm@linux-foundation.org>
Openpgp: url=http://www.shadowen.org/~apw/public-key
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64N.0705291258390.14456@blysk.ds.pg.gda.pl> <20070530011224.bf36d2df.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.9 (X11/20061220)
Andrew Morton wrote:
> On Tue, 29 May 2007 14:03:54 +0100 (BST) "Maciej W. Rozycki" 
> <macro@linux-mips.org> wrote:

> Hey, you have volatiles and checkpatch.pl didn't complain.  Andy, a
> reference to Documentation/volatile-considered-harmful.txt would suit.
> 
> (That's
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/broken-out/volatile-considered-harmful-take-3.patch)

Added ...

Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
PATCH: XXX.eml:374:
FILE: linux-2.6.22-rc2/drivers/serial/zs.c:131:
+       volatile void __iomem *control = zport->port.membase +

[...]

I will batch up any changes to checkpatch.pl and send you them as a blob
when they get "interesting" if that suits.

-apw

<Prev in Thread] Current Thread [Next in Thread>