linux-mips
[Top] [All Lists]

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver
From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 24 May 2007 18:25:36 -0400
Cc: Marc St-Jean <stjeanma@pmc-sierra.com>, akpm@linux-foundation.org, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <46560E06.9090506@pmc-sierra.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46560E06.9090506@pmc-sierra.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.10 (X11/20070302)
Marc St-Jean wrote:
I asked if the remaining section (above) was acceptable so we could retain our
buffer recycling which enhances throughput. I never received a rely so it was
left in my last patch.

The above comment now answers my part of my initial question. Are you aware of
a better way to implement this or must we lose all our recycling enhancements?


You can poke around on netdev and ask about skb recycling in a new thread, and propose something.

I just know that having your own custom skb initialization is a non-starter. Any updates the main skb init code receives will inevitably -not- be propagate to your code, rapidly leading to an unmaintainable disconnect.

skb recycling in general is an interesting area to explore, and others have poked around that area before. I bet googling for skb recycling would turn up some useful thoughts and past efforts.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>