linux-mips
[Top] [All Lists]

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

To: Marc St-Jean <stjeanma@pmc-sierra.com>
Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver
From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 24 May 2007 17:46:05 -0400
Cc: akpm@linux-foundation.org, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <200705101839.l4AIdHB9030885@pasqua.pmc-sierra.bc.ca>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200705101839.l4AIdHB9030885@pasqua.pmc-sierra.bc.ca>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.10 (X11/20070302)
Marc St-Jean wrote:
+inline static void
+mspeth_skb_headerinit(struct sk_buff *skb)
+{
+       /* these are essential before init */
+       dst_release(skb->dst);
+#ifdef CONFIG_XFRM
+       secpath_put(skb->sp);
+#endif
+#ifdef CONFIG_NETFILTER
+       nf_conntrack_put(skb->nfct);
+#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
+       nf_conntrack_put_reasm(skb->nfct_reasm);
+#endif
+#ifdef CONFIG_BRIDGE_NETFILTER
+       nf_bridge_put(skb->nf_bridge);
+#endif
+#endif /* CONFIG_NETFILTER */
+
+       /*
+        * Now initialise the skb...
+        * Clear the members till skb->truesize.
+        */
+       memset(skb, 0, offsetof(struct sk_buff, truesize));
+}
+#endif /* CONFIG_MSPETH_SKB_RECYCLE */

Did you ever resend this driver addition, with the above unmaintainable skb init hacks removed?

        Jeff



<Prev in Thread] Current Thread [Next in Thread>