linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] Add MIPS generic GPIO support

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/2] Add MIPS generic GPIO support
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date: Mon, 21 May 2007 16:13:03 +0900
Cc: yoichi_yuasa@tripeaks.co.jp, florian.fainelli@telecomint.eu, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20070521.001238.41198930.anemo@mba.ocn.ne.jp>
Organization: TriPeaks Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200705192151.37338.florian.fainelli@telecomint.eu> <20070520182301.7d7831e5.yoichi_yuasa@tripeaks.co.jp> <20070521.001238.41198930.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 21 May 2007 00:12:38 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:

> On Sun, 20 May 2007 18:23:01 +0900, Yoichi Yuasa 
> <yoichi_yuasa@tripeaks.co.jp> wrote:
> > diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/gpio.h 
> > gpio/include/asm-mips/gpio.h
> > --- gpio-orig/include/asm-mips/gpio.h       1970-01-01 09:00:00.000000000 
> > +0900
> > +++ gpio/include/asm-mips/gpio.h    2007-05-20 17:21:36.332456000 +0900
> > @@ -0,0 +1,6 @@
> > +#ifndef __ASM_MIPS_GPIO_H
> > +#define __ASM_MIPS_GPIO_H
> > +
> > +#include <gpio.h>
> > +
> > +#endif /* __ASM_MIPS_GPIO_H */
> 
> This looks good for me.
> 
> > diff -pruN -X gpio/Documentation/dontdiff 
> > gpio-orig/include/asm-mips/mach-generic/gpio.h 
> > gpio/include/asm-mips/mach-generic/gpio.h
> > --- gpio-orig/include/asm-mips/mach-generic/gpio.h  1970-01-01 
> > 09:00:00.000000000 +0900
> > +++ gpio/include/asm-mips/mach-generic/gpio.h       2007-05-20 
> > 17:24:07.401897250 +0900
> > @@ -0,0 +1,6 @@
> > +#ifndef __ASM_MACH_GENERIC_GPIO_H
> > +#define __ASM_MACH_GENERIC_GPIO_H
> > +
> > +/* no GPIO support */ 
> > +
> > +#endif /* __ASM_MACH_GENERIC_GPIO_H */
> 
> But is this really needed?  I can not see any point of this empty gpio.h ...

No, it is not must.
I'll update it soon.

Yoichi

<Prev in Thread] Current Thread [Next in Thread>