linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] Add MIPS generic GPIO support

To: yoichi_yuasa@tripeaks.co.jp
Subject: Re: [PATCH 1/2] Add MIPS generic GPIO support
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 21 May 2007 00:12:38 +0900 (JST)
Cc: florian.fainelli@telecomint.eu, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20070520182301.7d7831e5.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200705192151.37338.florian.fainelli@telecomint.eu> <20070520182301.7d7831e5.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 20 May 2007 18:23:01 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> 
wrote:
> diff -pruN -X gpio/Documentation/dontdiff gpio-orig/include/asm-mips/gpio.h 
> gpio/include/asm-mips/gpio.h
> --- gpio-orig/include/asm-mips/gpio.h 1970-01-01 09:00:00.000000000 +0900
> +++ gpio/include/asm-mips/gpio.h      2007-05-20 17:21:36.332456000 +0900
> @@ -0,0 +1,6 @@
> +#ifndef __ASM_MIPS_GPIO_H
> +#define __ASM_MIPS_GPIO_H
> +
> +#include <gpio.h>
> +
> +#endif /* __ASM_MIPS_GPIO_H */

This looks good for me.

> diff -pruN -X gpio/Documentation/dontdiff 
> gpio-orig/include/asm-mips/mach-generic/gpio.h 
> gpio/include/asm-mips/mach-generic/gpio.h
> --- gpio-orig/include/asm-mips/mach-generic/gpio.h    1970-01-01 
> 09:00:00.000000000 +0900
> +++ gpio/include/asm-mips/mach-generic/gpio.h 2007-05-20 17:24:07.401897250 
> +0900
> @@ -0,0 +1,6 @@
> +#ifndef __ASM_MACH_GENERIC_GPIO_H
> +#define __ASM_MACH_GENERIC_GPIO_H
> +
> +/* no GPIO support */ 
> +
> +#endif /* __ASM_MACH_GENERIC_GPIO_H */

But is this really needed?  I can not see any point of this empty gpio.h ...

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>