linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sat, 12 May 2007 20:58:54 +0200
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20070513.014713.74753298.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cda58cb80705110514g1098de81lec547e774eb76482@mail.gmail.com> <20070512.005905.26096031.anemo@mba.ocn.ne.jp> <cda58cb80705111223y5e94eafcy710b878517c48c48@mail.gmail.com> <20070513.014713.74753298.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Sun, May 13, 2007 at 01:47:13AM +0900, Atsushi Nemoto wrote:
> On Fri, 11 May 2007 21:23:55 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> 
> wrote:
> > Well I'm not sure how revelant are the echos...
> 
> Without the echos, you can get something like this and it seems unlear
> which ABI should be fixed.
> 
>   CALL    /home/git/linux-mips/scripts/checksyscalls.sh
>   ...
>   CALL    /home/git/linux-mips/scripts/checksyscalls.sh
>   ...
>   CALL    /home/git/linux-mips/scripts/checksyscalls.sh
>   ...
> 
> > But I still think that (a) you shouldn't put any command in
> > 'archprepare' multiple rule (b) you should move this rule from the
> > cleaning targets.
> 
> Oh, I missed those points.  Revised again.
> 
> 
> Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32

This is overengineered. The only reason to make the syscall check
for each and every build was that this was easy and the missing syscalls
are easy to spot during a normal build.
But checking all combinations is just not worth it.
The arch responsible are assumed to build for the different architectures
once in a while so a missing syscall are likely to be detected anyway.

We cannot run each and every consistency check in all combinations
for each build - that would end in only build noise.

        Sam

<Prev in Thread] Current Thread [Next in Thread>