linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 12 May 2007 00:59:05 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, sam@ravnborg.org
In-reply-to: <cda58cb80705110514g1098de81lec547e774eb76482@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070511.010234.74566169.anemo@mba.ocn.ne.jp> <cda58cb80705110514g1098de81lec547e774eb76482@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 11 May 2007 14:14:47 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> 
wrote:
> or can't we do instead:
> 
> $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
> 
> and get rid of "missing-syscalls-n32" rule. Thus this avoids to
> duplicate "missing-syscalls" command.

Thank you for suggestion.  How about this?


Subject: [PATCH] MIPS: Simplify missing-syscalls for N32 and O32

Use standard missing-syscalls with EXTRA_CFLAGS instead of duplicating
the command.  Suggested by Franck Bui-Huu.  Also add "echo" to show
the target ABI.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index f450066..25c7318 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -710,24 +710,12 @@ CLEAN_FILES += vmlinux.32 \
               vmlinux.64 \
               vmlinux.ecoff
 
-quiet_cmd_syscalls_n32 = CALL-N32 $<
-      cmd_syscalls_n32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=n32
-
-quiet_cmd_syscalls_o32 = CALL-O32 $<
-      cmd_syscalls_o32 = $(CONFIG_SHELL) $< $(CC) $(c_flags) -mabi=32
-
-PHONY += missing-syscalls-n32 missing-syscalls-o32
-
-missing-syscalls-n32: scripts/checksyscalls.sh FORCE
-       $(call cmd,syscalls_n32)
-
-missing-syscalls-o32: scripts/checksyscalls.sh FORCE
-       $(call cmd,syscalls_o32)
-
 archprepare:
 ifdef CONFIG_MIPS32_N32
-       $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-n32
+       @echo '  Checking missing-syscalls for N32'
+       $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=n32"
 endif
 ifdef CONFIG_MIPS32_O32
-       $(Q)$(MAKE) $(build)=arch/mips missing-syscalls-o32
+       @echo '  Checking missing-syscalls for O32'
+       $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
 endif

<Prev in Thread] Current Thread [Next in Thread>