linux-mips
[Top] [All Lists]

Re: [PATCH] mmc: au1xmmc command types check from data flags

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH] mmc: au1xmmc command types check from data flags
From: Pierre Ossman <drzeus@drzeus.cx>
Date: Fri, 11 May 2007 17:48:53 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20070511192948.38937fd0.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070511125919.350c53a8.yoichi_yuasa@tripeaks.co.jp> <4643F57C.5060409@drzeus.cx> <200705110516.l4B5GMQJ053603@mbox33.po.2iij.net> <4643FD2B.8020103@drzeus.cx> <20070511192948.38937fd0.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.0 (X11/20070419)
Yoichi Yuasa wrote:
> 
> Ok, I updated the patch for au1xmmc.c .
> 
> This patch has changed command types check from data flags.
> 

Perfect. That's just the way things should be.

> MMC_STOP_TRANSMISSION is never passed to au1xmmc_send_command().
> SEND_STOP() is used for MMC_STOP_TRANSMISSION.
> 

That SEND_STOP however is a long standing bug in this driver. Could I bother you
with fixing the driver so that it respects mrq->data->stop?

Rgds
Pierre


Attachment: signature.asc
Description: OpenPGP digital signature

<Prev in Thread] Current Thread [Next in Thread>