linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()

To: "Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Fri, 11 May 2007 14:26:30 +0200
Cc: "Atsushi Nemoto" <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tOLfcHRi38+wOICMN0aReWKT7Z5o6Eqei67hf8tUyn/WkX11SIMr5AIrkMsG99Vn12nwfPl6PaUHX8SjKeIgh6MerIQgLseYzEuVVbiDYlHFOG1T5ESsAnbImTvdW2fb4OKnBbRNxqsIzEAeu7QUtIYPstf8zKQkym+m1WLINd8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aH0AtztGMkd2foF8pqXW5pmJsq4PXj57az4+oF2JZqRCBJTFIuwjOPkgpK5WmExLLJXsbV+u0dNwqYagqz/AGUnO4thLxoQ2hVkEfIaDCo7Cb8GLTwLwwqzajxDr8GPcc8HVkgItMm5op/X2WFVmoUBLE1vwxTrfPXKYbj2zmks=
In-reply-to: <20070511114138.GH2732@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1178293006633-git-send-email-fbuihuu@gmail.com> <11782930063123-git-send-email-fbuihuu@gmail.com> <20070506.010313.41199101.anemo@mba.ocn.ne.jp> <20070511114138.GH2732@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
Hi Ralf !

On 5/11/07, Ralf Baechle <ralf@linux-mips.org> wrote:
On Sun, May 06, 2007 at 01:03:13AM +0900, Atsushi Nemoto wrote:

> How about keeping board_time_init pointer as is and adding
> plat_clk_setup only for simple platforms?

The idea of having such function pointer is quite nice.  In theory.  In

what about using function with weak attribute instead ? There's no
more need for a function pointer and no needs to initialise it too...

practice it seems alot of people who are bringing up Linux on a new
platform miss those hooks.  A new mandatory platform hook that if missing
is resulting in a linker error is preferable, I think.


Ok, but do you agree that we now need to call this hook earlier during
the boot process ?

Thanks
--
              Franck

<Prev in Thread] Current Thread [Next in Thread>