linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 11 May 2007 12:41:38 +0100
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org
In-reply-to: <20070506.010313.41199101.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1178293006633-git-send-email-fbuihuu@gmail.com> <11782930063123-git-send-email-fbuihuu@gmail.com> <20070506.010313.41199101.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Sun, May 06, 2007 at 01:03:13AM +0900, Atsushi Nemoto wrote:

> How about keeping board_time_init pointer as is and adding
> plat_clk_setup only for simple platforms?

The idea of having such function pointer is quite nice.  In theory.  In
practice it seems alot of people who are bringing up Linux on a new
platform miss those hooks.  A new mandatory platform hook that if missing
is resulting in a linker error is preferable, I think.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>