linux-mips
[Top] [All Lists]

Re: [PATCH] mmc: add include <linux/mmc/mmc.h> to au1xmmc.c

To: Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: [PATCH] mmc: add include <linux/mmc/mmc.h> to au1xmmc.c
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date: Fri, 11 May 2007 14:16:22 +0900
Cc: yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org
In-reply-to: <4643F57C.5060409@drzeus.cx>
Organization: TriPeaks Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070511125919.350c53a8.yoichi_yuasa@tripeaks.co.jp> <4643F57C.5060409@drzeus.cx>
Sender: linux-mips-bounce@linux-mips.org
Hi,

On Fri, 11 May 2007 06:47:56 +0200
Pierre Ossman <drzeus@drzeus.cx> wrote:

> Yoichi Yuasa wrote:
> > Hi,
> > 
> > This patch has fixed the following error about au1xmmc.c .
> > 
> > drivers/mmc/host/au1xmmc.c: In function 'au1xmmc_send_command':
> > drivers/mmc/host/au1xmmc.c:217: error: 'MMC_READ_SINGLE_BLOCK' undeclared 
> > (first use in this function)
> > drivers/mmc/host/au1xmmc.c:217: error: (Each undeclared identifier is 
> > reported only once
> > drivers/mmc/host/au1xmmc.c:217: error: for each function it appears in.)
> > drivers/mmc/host/au1xmmc.c:218: error: 'SD_APP_SEND_SCR' undeclared (first 
> > use in this function)
> > drivers/mmc/host/au1xmmc.c:221: error: 'MMC_READ_MULTIPLE_BLOCK' undeclared 
> > (first use in this function)
> > drivers/mmc/host/au1xmmc.c:224: error: 'MMC_WRITE_BLOCK' undeclared (first 
> > use in this function)
> > drivers/mmc/host/au1xmmc.c:228: error: 'MMC_WRITE_MULTIPLE_BLOCK' 
> > undeclared (first use in this function)
> > drivers/mmc/host/au1xmmc.c:231: error: 'MMC_STOP_TRANSMISSION' undeclared 
> > (first use in this function)
> > 
> > Yoichi
> > 
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> > 
> 
> NAK for now. I want an explanation what those opcodes are doing in a host 
> driver.

The commands of au1xmmc controller are different from standard commands. 
au1xmmc_send_command() convert standard commands to local commands for au1xmmc 
host controller,
and send local commands to controller.

Yoichi


<Prev in Thread] Current Thread [Next in Thread>