linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH 2/3] time: replace board_time_init() by plat_clk_setup()
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 06 May 2007 01:16:36 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <11782930063123-git-send-email-fbuihuu@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1178293006633-git-send-email-fbuihuu@gmail.com> <11782930063123-git-send-email-fbuihuu@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri,  4 May 2007 17:36:45 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> --- a/arch/mips/kernel/time.c
> +++ b/arch/mips/kernel/time.c
> @@ -239,21 +239,14 @@ asmlinkage void ll_local_timer_interrupt(int irq)
>  /*
>   * time_init() - it does the following things.
>   *
> - * 1) board_time_init() -
> - *   a) (optional) set up RTC routines,
> - *      b) (optional) calibrate and set the mips_hpt_frequency
> - *       (only needed if you intended to use cpu counter as timer interrupt
> - *        source)
> - * 2) setup xtime based on rtc_mips_get_time().
> - * 3) calculate a couple of cached variables for later usage
> - * 4) plat_timer_setup() -
> + * 1) setup xtime based on rtc_mips_get_time().
> + * 2) calculate a couple of cached variables for later usage
> + * 3) plat_timer_setup() -
>   *   a) (optional) over-write any choices made above by time_init().
>   *   b) machine specific code should setup the timer irqaction.
>   *   c) enable the timer interrupt
>   */
>  
> -void (*board_time_init)(void);
> -
>  unsigned int mips_hpt_frequency;
>  
>  static struct irqaction timer_irqaction = {

As I wrote in another mail I think we can not remove board_time_init
for now, but if you really removed it please update
Documentation/mips/time.README too.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>