linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

To: akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 01 May 2007 00:14:26 +0900 (JST)
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org, jeff@garzik.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com
In-reply-to: <20070429.021037.41179188.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070425.015549.108742168.anemo@mba.ocn.ne.jp> <20070428010414.2ba43a30.akpm@linux-foundation.org> <20070429.021037.41179188.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 29 Apr 2007 02:10:37 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> 
wrote:
> > platform_device_register_simple() copies *res by value, so I believe we can
> > make res[] static __initdata.  This way we don't need to evaluate the array
> > on the stack at runtime, and the data gets discarded after initcalls have
> > run.
> > 
> > Can you please review and test the below?  I had a go but wasn't able to
> > fumble my way to a suitable config (I hope):
> 
> It looks OK.  I will merge your fix to updated patch.  Thank you.

Unfortunately, the RBTX4938 part can not be converted to static
__initdata since RBTX4938_RTL_8019_BASE is not a constant.

And I think the change for toshiba_rbtx4927_rtc_init() should be an
another patch.  So I will add the "static __initdata" only to
rbtx4927_ne_init().

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>