linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX
From: Jeff Garzik <jeff@garzik.org>
Date: Sat, 28 Apr 2007 13:28:18 -0400
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com, akpm@linux-foundation.org
In-reply-to: <20070429.022428.71103613.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070425.015549.108742168.anemo@mba.ocn.ne.jp> <463363ED.3050307@garzik.org> <20070429.022428.71103613.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.10 (X11/20070302)
Atsushi Nemoto wrote:
On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <jeff@garzik.org> wrote:
 static unsigned int netcard_portlist[] __initdata = {
-       0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0
+#if defined(CONFIG_ISA) || defined(CONFIG_M32R)
+       0x300, 0x280, 0x320, 0x340, 0x360, 0x380,
+#endif
+       0
This looks a bit strange, and perhaps more difficult to maintain long term.

I would suggest creating a NEEDS_PORTLIST cpp macro at the top of ne.c, to be defined or undefined based on CONFIG_xxx symbols. Then, down in the code itself, conditionally include or exclude all portlist related data tables and code.

Sound sane?

Sure.  Do you mean something like this?

Correct.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>