| To: | akpm@linux-foundation.org |
|---|---|
| Subject: | Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Sun, 29 Apr 2007 02:10:37 +0900 (JST) |
| Cc: | linux-mips@linux-mips.org, netdev@vger.kernel.org, jeff@garzik.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com |
| In-reply-to: | <20070428010414.2ba43a30.akpm@linux-foundation.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070425.015549.108742168.anemo@mba.ocn.ne.jp> <20070428010414.2ba43a30.akpm@linux-foundation.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sat, 28 Apr 2007 01:04:14 -0700, Andrew Morton <akpm@linux-foundation.org> wrote: > platform_device_register_simple() copies *res by value, so I believe we can > make res[] static __initdata. This way we don't need to evaluate the array > on the stack at runtime, and the data gets discarded after initcalls have > run. > > Can you please review and test the below? I had a go but wasn't able to > fumble my way to a suitable config (I hope): It looks OK. I will merge your fix to updated patch. Thank you. And the lack of its defconfig should be fixed anyway, but it should be another story ... --- Atsushi Nemoto |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] ne: Add platform_driver, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH 1/3] ne: Add platform_driver, Atsushi Nemoto |
| Previous by Thread: | Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX, Andrew Morton |
| Next by Thread: | Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |