[Top] [All Lists]

Re: [PATCH 1/3] ne: Add platform_driver

Subject: Re: [PATCH 1/3] ne: Add platform_driver
From: Atsushi Nemoto <>
Date: Sun, 29 Apr 2007 01:40:26 +0900 (JST)
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
On Sat, 28 Apr 2007 00:57:27 -0700, Andrew Morton <> 
> > +#else /* MODULE */
> > +module_init(ne_init);
> > +module_exit(ne_exit);
> >  #endif /* MODULE */
> Are we sure about this part?  It is unusual to have special treatment 
> dependent
> upon MODULE.

Yes, it is unusual now, but ne.c has old-fashioned init_module() which
can not be used if it was built into kernel.  Also ne.c depends on
old-style initialization by Space.c.

Rewriting those old-style initialization code could be possible, but
it will involve much more changes and might cause compatibility issue
(if somebody depends on ethN order of built-in drivers).  So I chose
least intrusive way.

Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>