linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] ne: Add platform_driver

To: akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] ne: Add platform_driver
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 29 Apr 2007 01:40:26 +0900 (JST)
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org, jeff@garzik.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com
In-reply-to: <20070428005727.6414a24e.akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070425.015450.25909765.anemo@mba.ocn.ne.jp> <20070428005727.6414a24e.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 28 Apr 2007 00:57:27 -0700, Andrew Morton <akpm@linux-foundation.org> 
wrote:
> > +#else /* MODULE */
> > +module_init(ne_init);
> > +module_exit(ne_exit);
> >  #endif /* MODULE */
> 
> Are we sure about this part?  It is unusual to have special treatment 
> dependent
> upon MODULE.

Yes, it is unusual now, but ne.c has old-fashioned init_module() which
can not be used if it was built into kernel.  Also ne.c depends on
old-style initialization by Space.c.

Rewriting those old-style initialization code could be possible, but
it will involve much more changes and might cause compatibility issue
(if somebody depends on ethN order of built-in drivers).  So I chose
least intrusive way.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>