linux-mips
[Top] [All Lists]

Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 27 Mar 2007 12:12:32 +0900 (JST)
Cc: ralf@linux-mips.org, kumba@gentoo.org, linux-mips@linux-mips.org, ths@networkno.de
In-reply-to: <cda58cb80703260907g6f349298xf85b2e2954a7b6a7@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cda58cb80703260831t576ff7c5wef1e34e3367e7c45@mail.gmail.com> <20070327.004511.31449250.anemo@mba.ocn.ne.jp> <cda58cb80703260907g6f349298xf85b2e2954a7b6a7@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 26 Mar 2007 18:07:21 +0200, "Franck Bui-Huu" <vagabon.xyz@gmail.com> 
wrote:
> ok, I suppose a warning is fine. What about this patch on top of the patchset 
> ?
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 3ec0c12..b886945 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -627,7 +627,12 @@ ifdef CONFIG_64BIT
>    endif
> 
>    ifeq ($(KBUILD_SYM32), y)
> -    cflags-y += -msym32 -DKBUILD_64BIT_SYM32
> +    ifeq ($(call cc-option-yn,-msym32), y)
> +      cflags-y += -msym32 -DKBUILD_64BIT_SYM32
> +    else
> +      $(warning '-msym32' option is not supported by your compiler. \
> +               You should use a new one to get best result)
> +    endif
>    endif
>  endif

Well, I feel even a warning is intrusive, while it is not necessary
optimization.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>