linux-mips
[Top] [All Lists]

RE: [PATCH] NAPI support for Sibyte MAC

To: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>
Subject: RE: [PATCH] NAPI support for Sibyte MAC
From: "Mark E Mason" <mason@broadcom.com>
Date: Mon, 26 Mar 2007 14:33:57 -0700
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <460580BF.4040904@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AcduTXKYz5prVHl0TU+OKwVmIK1CZABoKKiQ
Thread-topic: [PATCH] NAPI support for Sibyte MAC
Hello, 

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@ru.mvista.com] 
> Sent: Saturday, March 24, 2007 12:49 PM
> To: Mark E Mason
> Cc: linux-mips@linux-mips.org; netdev@vger.kernel.org
> Subject: Re: [PATCH] NAPI support for Sibyte MAC

[snip]
> > @@ -2075,12 +2143,52 @@
> >              */
> >  
> >             if (isr & (M_MAC_INT_CHANNEL << S_MAC_TX_CH0)) {
> > -                   sbdma_tx_process(sc,&(sc->sbm_txdma));
> > +                   sbdma_tx_process(sc,&(sc->sbm_txdma), 0);
> > +#ifdef CONFIG_NETPOLL_TRAP
> > +                  if (netpoll_trap()) {
> > +                          if 
> (test_and_clear_bit(__LINK_STATE_XOFF, &dev->state)) 
> > +                                  __netif_schedule(dev);
> > +                  }
> > +#endif
> >             }
> 
>     This just doesn't make sense. That option is enabled to 
> *prevent* calls to 
> __netif_schedule() -- you can't override it that way. (Well, 
> how it works 
> currently, doesn't make much sense either since it totally 
> breaks the TX queue 
> control -- I was going to post a patch).

I'll admit - this was just copied over from the non-NAPI version we
started with ;-).

Are you saying that the #ifdef test should simply be an #ifndef here?

[I'm working on a revised patch based on feedback from Ralf and others
which removes the Kconfig option for NAPI - it'll just be on, all the
time.]

Thanks,
Mark


<Prev in Thread] Current Thread [Next in Thread>