linux-mips
[Top] [All Lists]

Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely

To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely
From: Thiemo Seufer <ths@networkno.de>
Date: Mon, 26 Mar 2007 16:56:33 +0100
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, ralf@linux-mips.org, kumba@gentoo.org, linux-mips@linux-mips.org
In-reply-to: <cda58cb80703260831t576ff7c5wef1e34e3367e7c45@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4606AA74.3070907@gentoo.org> <20070325221919.GA12088@linux-mips.org> <cda58cb80703260654u4435b90axa28507f6c9011c00@mail.gmail.com> <20070326.234821.30439266.anemo@mba.ocn.ne.jp> <cda58cb80703260831t576ff7c5wef1e34e3367e7c45@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
Franck Bui-Huu wrote:
> Hi Atsushi,
> 
> On 3/26/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> >One thing I noticed recently: Your patchset dropped gcc test for
> >availability of -msym32, so may not work with gcc 3.x.
> >
> 
> I suspect you're asking why I did not do this:
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 3ec0c12..b0d8240 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -627,7 +627,7 @@ ifdef CONFIG_64BIT
>   endif
> 
>   ifeq ($(KBUILD_SYM32), y)
> -    cflags-y += -msym32 -DKBUILD_64BIT_SYM32
> +    cflags-y += $(call cc-option,-msym32) -DKBUILD_64BIT_SYM32
>   endif
> endif
> 
> I remove the call to cc-option because this function removes
> _silently_ '-msym32' option if it's not supported by the compiler. IOW
> it's really not what we want.

It is _exactly_ what we want. -msym32 is always an optional optimization.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>