| To: | "Atsushi Nemoto" <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely |
| From: | "Franck Bui-Huu" <vagabon.xyz@gmail.com> |
| Date: | Mon, 26 Mar 2007 17:31:18 +0200 |
| Cc: | ralf@linux-mips.org, kumba@gentoo.org, linux-mips@linux-mips.org, ths@networkno.de |
| Dkim-signature: | a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=noZZYmb60KRkyST5hnGs5lutJuNXA082c+H6LCBoF2g0VXWEh/miXdg8xp4YQkj1Oc+vzKFXhH43wPJsAAW+ETLPmeQlUIz6MiDhg0RU9Zs7xO/3OFTU2aRjC/1mOjoxM2aZnfYQgtLD8XrsZyWRqz8875VHIf3u5J8x/piMt9s= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nXlx7aX2xYyzB77Y0CUyIqxrwb4dTF9YvRxRW1B/XJb+I2H5J/jR+Mv1UWvkqx0O6d9VBaqQrBGWJylBlG7AcAzF/Z2zHO6jCvkAH2K3w2aGFmK/SuA5uq6DXnule9xWqbWG1fWQgapcZy+or5XNh1l+h3NdDG0Uqr+TWoPnsTM= |
| In-reply-to: | <20070326.234821.30439266.anemo@mba.ocn.ne.jp> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <4606AA74.3070907@gentoo.org> <20070325221919.GA12088@linux-mips.org> <cda58cb80703260654u4435b90axa28507f6c9011c00@mail.gmail.com> <20070326.234821.30439266.anemo@mba.ocn.ne.jp> |
| Sender: | linux-mips-bounce@linux-mips.org |
Hi Atsushi, On 3/26/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote: One thing I noticed recently: Your patchset dropped gcc test for availability of -msym32, so may not work with gcc 3.x.
I suspect you're asking why I did not do this:
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 3ec0c12..b0d8240 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -627,7 +627,7 @@ ifdef CONFIG_64BIT
endif
ifeq ($(KBUILD_SYM32), y)
- cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+ cflags-y += $(call cc-option,-msym32) -DKBUILD_64BIT_SYM32
endif
endif
I remove the call to cc-option because this function removes
_silently_ '-msym32' option if it's not supported by the compiler. IOW
it's really not what we want.
IIRC I haven't found an other function like 'cc-option-strict' which
makes a compilation error in case.
So I assumed that the compiler will complain if it doesn't understand
this option. But it may be incorrect. If so I can add an error message
in Kbuild or add a new Kbuild helper. But I'd like to understand
what's wrong with it before.
Thanks
--
Franck
|
| Previous by Date: | Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely, Atsushi Nemoto |
| Previous by Thread: | Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely, Atsushi Nemoto |
| Next by Thread: | Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |