linux-mips
[Top] [All Lists]

Re: flush_anon_page for MIPS

To: ralf@linux-mips.org
Subject: Re: flush_anon_page for MIPS
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Fri, 23 Mar 2007 17:22:22 +0100
Cc: linux-mips@linux-mips.org, Ravi.Pratap@hillcrestlabs.com
In-reply-to: <20070323141939.GB17311@linux-mips.org> (message from Ralf Baechle on Fri, 23 Mar 2007 14:19:39 +0000)
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <E1HUVlw-00034H-00@dorka.pomaz.szeredi.hu> <20070323141939.GB17311@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
Ralf,

Thanks for looking into this.

> See why such stuff is happening?  Providing a default implemntation may be
> fine for i.e. strcpy() where it's only about providing a better mouse
> trap than the standard one in lib/string.c.  It's an awfully bad idea for
> something that matters for correctness such as flush_anon_page() ...

Well, James Bottomley discussed this approach on linux-arch back then,
so you could have raised objections.

I don't like this whole flush_anon_page() approach, but nobody
(including me) seems to be interested enough in finding a better one ;)

Miklos

<Prev in Thread] Current Thread [Next in Thread>