linux-mips
[Top] [All Lists]

Re: [PATCH] Netpoll support for Sibyte MAC

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] Netpoll support for Sibyte MAC
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 20 Mar 2007 21:35:53 +0300
Cc: dsaxena@plexity.net, netdev@vger.kernel.org, ralf@linux-mips.org, jeff@garzik.org, linux-mips@linux-mips.org, mlachwani@mvista.com
In-reply-to: <20070320.102248.68134682.nemoto@toshiba-tops.co.jp>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070319224311.GA10176@plexity.net> <20070320.102248.68134682.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Atsushi Nemoto wrote:

NETPOLL support for Sibyte MAC

Signed-off-by: Manish Lachwani <mlachwani@mvista.com>
Signed-off-by: Deepak Saxena <dsaxena@mvista.com>

If you added NETPOLL support, do not forget to ensure hard_start_xmit
routine callable from interrupt context (or irq disabled).
See commit bce305f4fe779f29d99d414685243f5da0803254 for example.

You're absolutely right: this driver is very likely to blow up the caller when called with interrupts disabled -- it uses spin_unlock_irq() there! This *must* be fixed.

---
Atsushi Nemoto

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>