linux-mips
[Top] [All Lists]

Re: [PATCH] Always use virt_to_phys() when translating kernel addresses

To: Franck <vagabon.xyz@gmail.com>
Subject: Re: [PATCH] Always use virt_to_phys() when translating kernel addresses
From: Maxime Bizon <mbizon@freebox.fr>
Date: Mon, 19 Mar 2007 17:02:49 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <45FE5ADA.3030309@innova-card.com>
Organization: Freebox
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45FE5ADA.3030309@innova-card.com>
Reply-to: mbizon@freebox.fr
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2007-03-19 at 10:41 +0100, Franck Bui-Huu wrote:

Hi Franck,

> This patch fixes two places where we used plain 'x - PAGE_OFFSET' to
> achieve virtual to physical address convertion. This type of convertion
> is no more allowed since commit 6f284a2ce7b8bc49cb8455b1763357897a899abb.

I think you should also review arch/mips/mm/dma-noncoherent.c, it seems
to use PAGE_OFFSET directly in dma_unmap_single. I'm using OWN_DMA so
this code is not used on my board.
 
Regards,

-- 
Maxime


<Prev in Thread] Current Thread [Next in Thread>