linux-mips
[Top] [All Lists]

Re: [PATCH 8/12] drivers: PMC MSP71xx TWI driver]

To: Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH 8/12] drivers: PMC MSP71xx TWI driver]
From: Ladislav Michl <ladis@linux-mips.org>
Date: Mon, 19 Mar 2007 11:41:55 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Marc St-Jean <stjeanma@pmc-sierra.com>, akpm@linux-foundation.org, linux-mips@linux-mips.org, i2c@lm-sensors.org
In-reply-to: <20070317085244.f99aad86.khali@linux-fr.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070316230333.GA17478@linux-mips.org> <20070317085244.f99aad86.khali@linux-fr.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Sat, Mar 17, 2007 at 08:52:44AM +0100, Jean Delvare wrote:
[snip]
> Why are you making a separate algorithm driver? This should really only
> be done when the algorithm is very generic. This is the exception, not
> the rule. These days I tend to move algorithm code back into the only
> bus driver that uses them (i2c-algo-sibyte done recently, i2c-algo-sgi
> is next on my list.)

Please remove i2c-algo-sgi from your list. This algorithm is used by
the VINO asic (drivers/media/video/vino.c) present in SGI Indy machines as
well as by the MACE asic (no driver exist yet) present in SGI O2 machines.
You may consider applying this patch (also removes trailing whitespace).

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>

--- linux-omap-2.6.git/drivers/i2c/algos/i2c-algo-sgi.c.orig    2007-03-19 
11:26:30.000000000 +0100
+++ linux-omap-2.6.git/drivers/i2c/algos/i2c-algo-sgi.c 2007-03-19 
11:39:00.000000000 +0100
@@ -1,6 +1,7 @@
 /*
- * i2c-algo-sgi.c: i2c driver algorithms for SGI adapters.
- * 
+ * i2c-algo-sgi.c: i2c driver algorithm used by the VINO (SGI Indy) and
+ * MACE (SGI O2) chips.
+ *
  * This file is subject to the terms and conditions of the GNU General Public
  * License version 2 as published by the Free Software Foundation.
  *
@@ -162,8 +163,8 @@
        .functionality  = sgi_func,
 };
 
-/* 
- * registering functions to load algorithms at runtime 
+/*
+ * registering functions to load algorithms at runtime
  */
 int i2c_sgi_add_bus(struct i2c_adapter *adap)
 {

<Prev in Thread] Current Thread [Next in Thread>