linux-mips
[Top] [All Lists]

Re: [PATCH] Fix some system calls with long long arguments

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix some system calls with long long arguments
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 16 Mar 2007 01:33:34 +0900 (JST)
Cc: ralf@linux-mips.org, kraj@mvista.com, libc-ports@sourceware.org
In-reply-to: <20070315.103511.89758184.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070315.103511.89758184.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 15 Mar 2007 10:35:11 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> 
wrote:
> > > fadvise64(), readahead(), sync_file_range() have long long argument(s)
> > > but glibc passes it by hi/lo pair without padding, on both O32 and
> > > N32.

BTW, I can not find sync_file_range symbol in my libc.so.  There is
sysdeps/unix/sysv/linux/sync_file_range.c but it seems not built into
library.

Is this a correct fix?

--- glibc-2.5.org/sysdeps/unix/sysv/linux/Makefile      2006-04-26 
04:12:04.000000000 +0900
+++ glibc-2.5/sysdeps/unix/sysv/linux/Makefile  2007-03-16 01:25:28.654940581 
+0900
@@ -13,7 +13,7 @@
 
 ifeq ($(subdir),misc)
 sysdep_routines += sysctl clone llseek umount umount2 readahead \
-                  setfsuid setfsgid makedev
+                  setfsuid setfsgid makedev sync_file_range
 
 CFLAGS-gethostid.c = -fexceptions
 

<Prev in Thread] Current Thread [Next in Thread>