On Thu, Mar 15, 2007 at 05:02:50PM +0300, Sergei Shtylyov wrote:
> >diff --git a/include/asm-mips/mach-au1x00/au1xxx_ide.h
> >b/include/asm-mips/mach-au1x00/au1xxx_ide.h
> >index e9fa252..e747814 100644
> >--- a/include/asm-mips/mach-au1x00/au1xxx_ide.h
> >+++ b/include/asm-mips/mach-au1x00/au1xxx_ide.h
> >@@ -166,13 +166,13 @@ int __init auide_probe(void);
> > static int auide_dma_setup(ide_drive_t *drive);
> > static int auide_dma_check(ide_drive_t *drive);
> > static int auide_dma_test_irq(ide_drive_t *drive);
> >- static int auide_dma_host_off(ide_drive_t *drive);
> >- static int auide_dma_host_on(ide_drive_t *drive);
> >+ static void auide_dma_host_off(ide_drive_t *drive);
> >+ static void auide_dma_host_on(ide_drive_t *drive);
> > static int auide_dma_lostirq(ide_drive_t *drive);
> > static int auide_dma_on(ide_drive_t *drive);
> > static void auide_ddma_tx_callback(int irq, void *param);
> > static void auide_ddma_rx_callback(int irq, void *param);
> >- static int auide_dma_off_quietly(ide_drive_t *drive);
> >+ static void auide_dma_off_quietly(ide_drive_t *drive);
> > #endif /* end CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA */
>
> WTF these protos are doing in include/asm-mips/ -- being purely IDE
> subsystem specific?! :-O
> Could you move them into the driver (if they are indeed necessary)?
You're right.
This patch removes the static prototypes from the au1xxx_ide.h, some of
them were not even implemented.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
au1xxx_ide.h.patch
Description: Text document
|