linux-mips
[Top] [All Lists]

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
From: Jeff Garzik <jeff@garzik.org>
Date: Wed, 14 Mar 2007 05:59:51 -0400
Cc: shemminger@linux-foundation.org, linux-mips@linux-mips.org, ralf@linux-mips.org, netdev@vger.kernel.org, sshtylyov@ru.mvista.com, akpm@linux-foundation.org
In-reply-to: <20070314.100557.33857330.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070303.235459.25478204.anemo@mba.ocn.ne.jp> <20070314.010220.65192616.anemo@mba.ocn.ne.jp> <20070313120418.554a3a43@freekitty> <20070314.100557.33857330.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.10 (X11/20070302)
Atsushi Nemoto wrote:
On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger 
<shemminger@linux-foundation.org> wrote:
+ *     1.35    Fix an usage of streaming DMA API.
  */
Please don't use comments as changelog anymore. It gets out of date.
The use of change control systems has made this practice obsolete.

OK, Jeff, should I send a revised patch dropping this line?

Nah, there's no need to reject the patch on that basis.

You should send an additional patch, on top of all others you sent recently, that completely removes the entire changelog from the driver source code :)

        Jeff



<Prev in Thread] Current Thread [Next in Thread>