linux-mips
[Top] [All Lists]

[PATCH] store sign-extend register values for PTRACE_GETREGS

To: linux-mips@linux-mips.org
Subject: [PATCH] store sign-extend register values for PTRACE_GETREGS
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 04 Mar 2007 02:41:52 +0900 (JST)
Cc: ralf@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
A comment on ptrace_getregs() states "Registers are sign extended to
fill the available space." but it is not true.  Fix code to match the
comment.  Also fix casts on each caller to get rid of some warnings.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
index 478355a..5560b6d 100644
--- a/arch/mips/kernel/ptrace.c
+++ b/arch/mips/kernel/ptrace.c
@@ -66,13 +66,13 @@ int ptrace_getregs (struct task_struct *
        regs = task_pt_regs(child);
 
        for (i = 0; i < 32; i++)
-               __put_user (regs->regs[i], data + i);
-       __put_user (regs->lo, data + EF_LO - EF_R0);
-       __put_user (regs->hi, data + EF_HI - EF_R0);
-       __put_user (regs->cp0_epc, data + EF_CP0_EPC - EF_R0);
-       __put_user (regs->cp0_badvaddr, data + EF_CP0_BADVADDR - EF_R0);
-       __put_user (regs->cp0_status, data + EF_CP0_STATUS - EF_R0);
-       __put_user (regs->cp0_cause, data + EF_CP0_CAUSE - EF_R0);
+               __put_user ((long)regs->regs[i], data + i);
+       __put_user ((long)regs->lo, data + EF_LO - EF_R0);
+       __put_user ((long)regs->hi, data + EF_HI - EF_R0);
+       __put_user ((long)regs->cp0_epc, data + EF_CP0_EPC - EF_R0);
+       __put_user ((long)regs->cp0_badvaddr, data + EF_CP0_BADVADDR - EF_R0);
+       __put_user ((long)regs->cp0_status, data + EF_CP0_STATUS - EF_R0);
+       __put_user ((long)regs->cp0_cause, data + EF_CP0_CAUSE - EF_R0);
 
        return 0;
 }
@@ -403,11 +403,11 @@ long arch_ptrace(struct task_struct *chi
                }
 
        case PTRACE_GETREGS:
-               ret = ptrace_getregs (child, (__u64 __user *) data);
+               ret = ptrace_getregs (child, (__s64 __user *) data);
                break;
 
        case PTRACE_SETREGS:
-               ret = ptrace_setregs (child, (__u64 __user *) data);
+               ret = ptrace_setregs (child, (__s64 __user *) data);
                break;
 
        case PTRACE_GETFPREGS:
diff --git a/arch/mips/kernel/ptrace32.c b/arch/mips/kernel/ptrace32.c
index d9a39c1..2c60320 100644
--- a/arch/mips/kernel/ptrace32.c
+++ b/arch/mips/kernel/ptrace32.c
@@ -346,11 +346,11 @@ asmlinkage int sys32_ptrace(int request,
                }
 
        case PTRACE_GETREGS:
-               ret = ptrace_getregs (child, (__u64 __user *) (__u64) data);
+               ret = ptrace_getregs (child, (__s64 __user *) (__u64) data);
                break;
 
        case PTRACE_SETREGS:
-               ret = ptrace_setregs (child, (__u64 __user *) (__u64) data);
+               ret = ptrace_setregs (child, (__s64 __user *) (__u64) data);
                break;
 
        case PTRACE_GETFPREGS:

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] store sign-extend register values for PTRACE_GETREGS, Atsushi Nemoto <=