linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_d

To: Dale Farnsworth <dale@farnsworth.org>
Subject: Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data
From: Jeff Garzik <jgarzik@pobox.com>
Date: Fri, 02 Mar 2007 20:17:16 -0500
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <20070301233148.GA19550@xyzzy.farnsworth.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070301233148.GA19550@xyzzy.farnsworth.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.9 (X11/20070212)
Dale Farnsworth wrote:
The information contained within platform_data should be self-contained.
Replace the pointer to a MAC address with the actual MAC address in
struct mv643xx_eth_platform_data.

Signed-off-by: Dale Farnsworth <dale@farnsworth.org>

---

Replaced explicit mac address comparison with a call to is_valid_ether_addr(),
as suggested by Stephen Hemminger <shemminger@linux-foundation.org>.

 arch/mips/momentum/jaguar_atx/platform.c |   20 ++++----------------
 arch/mips/momentum/ocelot_3/platform.c   |   20 ++++----------------
 arch/mips/momentum/ocelot_c/platform.c   |   12 ++----------
 drivers/net/mv643xx_eth.c                |    2 +-
 include/linux/mv643xx.h                  |    2 +-
 5 files changed, 12 insertions(+), 44 deletions(-)

applied



<Prev in Thread] Current Thread [Next in Thread>