linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platfor

To: "Dale Farnsworth" <dale@farnsworth.org>
Subject: Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 28 Feb 2007 15:11:03 -0800
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <20070228224031.GA8233@xyzzy.farnsworth.org>
Organization: Linux Foundation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070228224031.GA8233@xyzzy.farnsworth.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 28 Feb 2007 15:40:31 -0700
"Dale Farnsworth" <dale@farnsworth.org> wrote:

> The information contained within platform_data should be self-contained.
> Replace the pointer to a MAC address with the actual MAC address in
> struct mv643xx_eth_platform_data.
> 
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> 
> Index: b/drivers/net/mv643xx_eth.c
> ===================================================================
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -1380,7 +1380,9 @@ static int mv643xx_eth_probe(struct plat
>  
>       pd = pdev->dev.platform_data;
>       if (pd) {
> -             if (pd->mac_addr)
> +             static u8 zero_mac_addr[6] = { 0 };
> +
> +             if (memcmp(pd->mac_addr, zero_mac_addr, 6) != 0)
>                       memcpy(dev->dev_addr, pd->mac_addr, 6);


is_zero_ether_addr() is faster/cleaner for this

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

<Prev in Thread] Current Thread [Next in Thread>