linux-mips
[Top] [All Lists]

Re: [PATCH 2/5] mips: PMC MSP71xx mips common

To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Subject: Re: [PATCH 2/5] mips: PMC MSP71xx mips common
From: Thiemo Seufer <ths@networkno.de>
Date: Tue, 27 Feb 2007 17:38:41 +0000
Cc: Andrew Sharp <tigerand@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <45E465C1.50408@pmc-sierra.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45E465C1.50408@pmc-sierra.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
Marc St-Jean wrote:
[snip]
> >  > +#ifdef CONFIG_PMC_MSP
> >  > +     jal     kernel_entry
> >  > +#else

Maybe introduce a CONFIG_BOOT_RAW (and use it in arch/mips/Makefile
to objcopy the kernel to a raw binary).

> >  > +     /*
> >  >        * Reserved space for exception handlers.
> >  >        * Necessary for machines which link their kernels at KSEG0.
> >  >        */
> >  >       .fill   0x400
> >  > +#endif /* CONFIG_PMC_MSP */
> > 
> > This is getting kind of ugly.  There are a whole lot of config choices
> > that need to use the 'j kernel_entry'.  Do they all have to have their
> > own?  I'm not sure what the best way is to handle them all.
> 
> I agree but don't know the best way to handle this. I could introduce a
> SYS_NO_EXEPT_FILL or similar flag but this seems excessive.
> 
> Any other ideas from arch/mips folks?

Something like

#if LOADADDR == 0xffffffff80000000
        .fill   0x400
#endif

but by defining an appropriate name in arch/mips/Makefile instead of
externalizing the load-y/LOADADDR there.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>