linux-mips
[Top] [All Lists]

Re: [RFC][NET] Alignment in mv643xx_eth

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [RFC][NET] Alignment in mv643xx_eth
From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 27 Feb 2007 04:21:56 -0500
Cc: Dale Farnsworth <dale@farnsworth.org>, netdev@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20070226195206.GA10188@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070226195206.GA10188@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.9 (X11/20070212)
Ralf Baechle wrote:
The driver contains this little piece of candy:

#if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE)
#define ETH_DMA_ALIGN           L1_CACHE_BYTES
#else
#define ETH_DMA_ALIGN           8
#endif

Any reason why we're not using dma_get_cache_alignment() instead?

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

applied



<Prev in Thread] Current Thread [Next in Thread>