linux-mips
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [RFC][NET] Alignment in mv643xx_eth

from [Dale Farnsworth] [Permanent Link][Original]
To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [RFC][NET] Alignment in mv643xx_eth
From: "Dale Farnsworth" <dale@farnsworth.org>
Date: Mon, 26 Feb 2007 14:48:46 -0700
Cc: Dale Farnsworth <dale@farnsworth.org>, netdev@vger.kernel.org, linux-mips@linux-mips.org, Jeff Garzik <jeff@garzik.org>
In-reply-to: <20070226195206.GA10188@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070226195206.GA10188@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11) 
On Mon, Feb 26, 2007 at 07:52:06PM +0000, Ralf Baechle wrote:
> The driver contains this little piece of candy:
> 
> #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE)
> #define ETH_DMA_ALIGN           L1_CACHE_BYTES
> #else
> #define ETH_DMA_ALIGN           8
> #endif
> 
> Any reason why we're not using dma_get_cache_alignment() instead?

Not that I can think of.

ACK.

Dale Farnsworth
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: possible bug in net/tc35815.c in linux-2.6.19, Sergei Shtylyov
Next by Date:  [PATCH] drivers: PMC MSP71xx TWI driver, Marc St-Jean
Previous by Thread:  [RFC][NET] Alignment in mv643xx_eth, Ralf Baechle
Next by Thread:  Re: [RFC][NET] Alignment in mv643xx_eth, Jeff Garzik
Indexes:  [Date] [Thread] [Top] [All Lists]