linux-mips
[Top] [All Lists]

section mismatches (Re: [PATCH] Drop __init from init_8259A())

To: ralf@linux-mips.org
Subject: section mismatches (Re: [PATCH] Drop __init from init_8259A())
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 21 Feb 2007 01:49:47 +0900 (JST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20070220151128.GA649@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070220.200845.98359099.nemoto@toshiba-tops.co.jp> <20070220151128.GA649@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 20 Feb 2007 15:11:28 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> > init_8259A() is called from i8259A_resume() so should not be marked as
> > __init.  And add some tests for whether 8259A was already initialized
> > or not.
> > 
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> Thanks, applied.

Thanks.  Apparently modpost can not detect section mismatchs in kernel.

Here is an excerpt from
        find . \! -name scripts -name '*.o' | xargs -n 1 scripts/mod/modpost
in malta build directory:

WARNING: ./arch/mips/kernel/built-in.o - Section mismatch: reference to 
.init.text:cpu_probe from .text between 'start_secondary' (at offset 0x8c1c) 
and 'smp_prepare_boot_cpu'
WARNING: ./arch/mips/kernel/built-in.o - Section mismatch: reference to 
.init.text:cpu_report from .text between 'start_secondary' (at offset 0x8c24) 
and 'smp_prepare_boot_cpu'
WARNING: ./arch/mips/kernel/built-in.o - Section mismatch: reference to 
.init.text:per_cpu_trap_init from .text between 'start_secondary' (at offset 
0x8c2c) and 'smp_prepare_boot_cpu'
WARNING: ./arch/mips/pci/built-in.o - Section mismatch: reference to 
.init.text: from .text between 'pcibios_fixup_bus' (at offset 0x1ac) and 
'pcibios_enable_device'
WARNING: ./arch/mips/pci/built-in.o - Section mismatch: reference to 
.init.text: from .text between 'pcibios_fixup_bus' (at offset 0x1f8) and 
'pcibios_enable_device'
WARNING: ./arch/mips/pci/pci.o - Section mismatch: reference to .init.text: 
from .text between 'pcibios_fixup_bus' (at offset 0x1ac) and 
'pcibios_enable_device'
WARNING: ./arch/mips/pci/pci.o - Section mismatch: reference to .init.text: 
from .text between 'pcibios_fixup_bus' (at offset 0x1f8) and 
'pcibios_enable_device'

In pci.c, __devinit pcibios_fixup_bus() calls __init
pcibios_fixup_device_resources(), so it seems to be fixed.
Maybe it is worth looking at others...

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>