linux-mips
[Top] [All Lists]

Re: [PATCH] Make __declare_dbe_table() static

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] Make __declare_dbe_table() static
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sun, 18 Feb 2007 16:13:52 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20070219.005850.96686775.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070219.004435.25910295.anemo@mba.ocn.ne.jp> <20070218155408.GA24660@linux-mips.org> <20070219.005850.96686775.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Mon, Feb 19, 2007 at 12:58:50AM +0900, Atsushi Nemoto wrote:

> On Sun, 18 Feb 2007 15:54:08 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> > > Make __declare_dbe_table() static and call it explicitly to ensure not
> > > optimized out.
> > 
> > That's what __attribute_used__ was meant to be used for.
> 
> But we do not need empty __declare_dbe_table() function body (jr ra +
> nop) at all.  If we called it explicitly, compiler will optimized it
> out.  Saves two instructions ;)

_asm__(
"       .section        __dbe_table, \"a\"\n"
"       .previous                       \n");

is even simpler :-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>