| To: | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Subject: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er |
| From: | Marc St-Jean <Marc_St-Jean@pmc-sierra.com> |
| Date: | Fri, 16 Feb 2007 08:30:28 -0800 |
| Cc: | Marc St-Jean <stjeanma@pmc-sierra.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-serial@vger.kernel.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 1.5.0.9 (X11/20061206) |
Andrew Morton wrote: > On Thu, 15 Feb 2007 13:26:29 -0600 > Marc St-Jean <stjeanma@pmc-sierra.com> wrote: > > > + status = *(volatile u32 *)up->port.private_data; > > It distresses me that this patch uses a variable which this patch > doesn't initialise anywhere. It isn't complete. > > The sub-driver code whch sets up this field shuld be included in the > patch, no? > OK, I'll re-post with the platform file which initializes the variable. That file however will reference other files in the platform which has not been posted yet. I thought it was better to post the driver-only code. Marc |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Fix __copy_{to,from}_user_inatomic, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er, Marc St-Jean |
| Previous by Thread: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er, Marc St-Jean |
| Next by Thread: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er, Marc St-Jean |
| Indexes: | [Date] [Thread] [Top] [All Lists] |