linux-mips
[Top] [All Lists]

Re: [PATCH] Fix __copy_{to,from}_user_inatomic

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 17 Feb 2007 01:12:20 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <45D5CEA5.3050604@innova-card.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45D5CEA5.3050604@innova-card.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 16 Feb 2007 16:32:53 +0100, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> These functions are aliases to __copy_{to,from}_user resp but they
> are not allowed to sleep. Therefore might_sleep() must not be used
> by their implementions.

This changes CONFIG_PREEMPT_VOLUNTARY behavior.
In this case might_sleep() is not just an annotation.

Well, so currently CONFIG_PREEMPT_VOLUNTARY seems broken.  Maybe we
need separete functions anyway.
---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>