linux-mips
[Top] [All Lists]

Re: [PATCH] Fix __copy_{to,from}_user_inatomic

To: "Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Fri, 16 Feb 2007 17:06:10 +0100
Cc: linux-mips <linux-mips@linux-mips.org>
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ZmjNnemaBCFTZpLrUp/fJu3+mL+aeZuamwX9GbxG+5mnTc6wKgP1rJoUgc8aXWQ7HYUH+vwIx6ohb3GPSzNVHMtlUx/L+zr+mP95oGRpHA6pmBX16bo+rQd9lekyRkzdUYRQrbIOln69Inxo7LaiNgkMS6ranBJb/vbq0uAx9LA=
In-reply-to: <20070216155441.GA26835@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45D5CEA5.3050604@innova-card.com> <20070216155441.GA26835@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On 2/16/07, Ralf Baechle <ralf@linux-mips.org> wrote:
On Fri, Feb 16, 2007 at 04:32:53PM +0100, Franck Bui-Huu wrote:

> These functions are aliases to __copy_{to,from}_user resp but they
> are not allowed to sleep. Therefore might_sleep() must not be used
> by their implementions.

The _inatomic functions are know to buggy but this doesn't quite fix the
whole issues with them.

ok so the patch's should have been: "Fix console warnings triggered by
__copy_{to,from}_user_inatomic()"

On error __copy_from_user_inatomic should not
clear the non-copied part of the destination buffer.  See
01408c4939479ec46c15aa7ef6e2406be50eeeca and
7c12d81134b130ccd4c286b434ca48c4cda71a2f for the rationale.

I'll try to take a look at it.

Thanks
--
              Franck

<Prev in Thread] Current Thread [Next in Thread>