| To: | Franck Bui-Huu <vagabon.xyz@gmail.com> |
|---|---|
| Subject: | Re: [PATCH] Fix __copy_{to,from}_user_inatomic |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Fri, 16 Feb 2007 15:54:42 +0000 |
| Cc: | linux-mips <linux-mips@linux-mips.org> |
| In-reply-to: | <45D5CEA5.3050604@innova-card.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <45D5CEA5.3050604@innova-card.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.2i |
On Fri, Feb 16, 2007 at 04:32:53PM +0100, Franck Bui-Huu wrote:
> These functions are aliases to __copy_{to,from}_user resp but they
> are not allowed to sleep. Therefore might_sleep() must not be used
> by their implementions.
The _inatomic functions are know to buggy but this doesn't quite fix the
whole issues with them. On error __copy_from_user_inatomic should not
clear the non-copied part of the destination buffer. See
01408c4939479ec46c15aa7ef6e2406be50eeeca and
7c12d81134b130ccd4c286b434ca48c4cda71a2f for the rationale.
Ralf
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: fadvise on MIPS, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH] Fix __copy_{to,from}_user_inatomic, Franck Bui-Huu |
| Previous by Thread: | [PATCH] Fix __copy_{to,from}_user_inatomic, Franck Bui-Huu |
| Next by Thread: | Re: [PATCH] Fix __copy_{to,from}_user_inatomic, Franck Bui-Huu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |