linux-mips
[Top] [All Lists]

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Fri, 16 Feb 2007 16:47:59 +0300
Cc: Marc St-Jean <stjeanma@pmc-sierra.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-serial@vger.kernel.org
In-reply-to: <20070215171035.83918aae.akpm@linux-foundation.org>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200702151926.l1FJQT2o020816@pasqua.pmc-sierra.bc.ca> <20070215171035.83918aae.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Andrew Morton wrote:

+                       status = *(volatile u32 *)up->port.private_data;

It distresses me that this patch uses a variable which this patch
doesn't initialise anywhere.  It isn't complete.

   I assume this gets passed via early_serial_setup(). Marc?

The sub-driver code whch sets up this field shuld be included in the
patch, no?

   Hardly so, this code (not a subdriver) resides under arch/mips/ I think.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>