| To: | Marc St-Jean <stjeanma@pmc-sierra.com> |
|---|---|
| Subject: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master |
| From: | Andrew Morton <akpm@linux-foundation.org> |
| Date: | Thu, 15 Feb 2007 17:10:35 -0800 |
| Cc: | linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-serial@vger.kernel.org |
| In-reply-to: | <200702151926.l1FJQT2o020816@pasqua.pmc-sierra.bc.ca> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200702151926.l1FJQT2o020816@pasqua.pmc-sierra.bc.ca> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 15 Feb 2007 13:26:29 -0600 Marc St-Jean <stjeanma@pmc-sierra.com> wrote: > + status = *(volatile u32 *)up->port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. The sub-driver code whch sets up this field shuld be included in the patch, no? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations., Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations., Andrew Morton |
| Previous by Thread: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master, Sergei Shtylyov |
| Next by Thread: | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master, Sergei Shtylyov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |