| To: | vagabon.xyz@gmail.com |
|---|---|
| Subject: | Re: [MIPS] Check FCSR for pending interrupts before restoring from a context. |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Thu, 15 Feb 2007 01:05:31 +0900 (JST) |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org, macro@linux-mips.org |
| In-reply-to: | <cda58cb80702140034g5f3243c9j333f97ae6fc6986@mail.gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070209.130316.14978798.nemoto@toshiba-tops.co.jp> <20070214.170420.85684996.nemoto@toshiba-tops.co.jp> <cda58cb80702140034g5f3243c9j333f97ae6fc6986@mail.gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Wed, 14 Feb 2007 09:34:53 +0100, "Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote: > > +/* Check and clear pending FPU exceptions in saved CSR */ > > +extern int fpcsr_pending(unsigned int __user *fpcsr); > > + > > Just my 2 cents: This looks like the wrong place for this fpu > prototype. I mean shouldn't it belong to a fpu header file or > something else ? Well, this is a helper function for signal so signal-common.h is not so bad, I think. And adding to kernel/signal-common.h looks less intrusive than adding to include/asm-mips/fpu.h, in my impression. --- Atsushi Nemoto |
| Previous by Date: | Re: [PATCH 2/3] Automatically set CONFIG_BUILD_ELF64, Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: [PATCH 2/3] Automatically set CONFIG_BUILD_ELF64, Atsushi Nemoto |
| Previous by Thread: | Re: [MIPS] Check FCSR for pending interrupts before restoring from a context., Franck Bui-Huu |
| Next by Thread: | Re: [MIPS] Check FCSR for pending interrupts before restoring from a context., Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |