linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] Automatically set CONFIG_BUILD_ELF64

To: "Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH 2/3] Automatically set CONFIG_BUILD_ELF64
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Tue, 13 Feb 2007 21:05:06 +0100
Cc: linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp, macro@linux-mips.org
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BqAUcNgq2NO2wJVqL8/IhAuLdnsZzvFWvChJAd5JafkQwU1MI1EWuhgJO2aDxToKAh5BoxoOxbpfgY9ag2Cn97C5OsywzENpGSnbhP9DDvoHG9HU9XzAYU+kzB/WDaMPJxtk8cw6EvHfqRP8bhXzb1S+C9nvKj+IIlnkGA5mOG8=
In-reply-to: <cda58cb80702130909u2c0cbe8fg6929fc78ca8d3cb8@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1171358289786-git-send-email-fbuihuu@gmail.com> <11713582901742-git-send-email-fbuihuu@gmail.com> <20070213161801.GA9700@linux-mips.org> <cda58cb80702130909u2c0cbe8fg6929fc78ca8d3cb8@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On 2/13/07, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
On 2/13/07, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Tue, Feb 13, 2007 at 10:18:08AM +0100, Franck Bui-Huu wrote:
>
> > +    cflags-y += -DCONFIG_BUILD_ELF64
>                    ^^^^^^^^^^^^^^^^^^^^
>
> Preprocessor symbol names starting CONFIG_ are reserved for Kbuild.
>

Ok but keeping this name avoid to change all places where
CONFIG_BUILD_ELF64 is used.

It should be done by patch #3 instead where CONFIG_BUILD_ELF64 is
renamed into CONFIG_64BIT_BUILD_ELF32. Any suggestions for a better
name ?

What about KBUILD_64BIT_ELF32 with 'KBUILD' meaning that it comes from
Kbuild itself and not from any Kconfig files ?

--
              Franck

<Prev in Thread] Current Thread [Next in Thread>