linux-mips
[Top] [All Lists]

More __get_user_asm_ll32 ...

To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: More __get_user_asm_ll32 ...
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 13 Feb 2007 13:32:51 +0000
Cc: linux-mips@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
__get_user_asm_ll32 contains a junk move %0, $0 left over from an older
version of the code.  Ignoring fixups code and data this instruction
inflates the normal path in __get_user() by 50% which may explain much of
the size and performance you have meassures.  It also always clears
the error return, iow. __get_user_asm_ll32(..., &<something 64-bit>)
would never have returned an error.  ARGH.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>