| To: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH 3/3] signal.c: fix gcc warning on 32 bits kernel |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 13 Feb 2007 02:05:56 +0000 |
| Cc: | vagabon.xyz@gmail.com, fbuihuu@gmail.com, linux-mips@linux-mips.org |
| In-reply-to: | <20070213014345.GA30988@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070209210014.GA26939@linux-mips.org> <cda58cb80702120101k770e059end43579394206b9d2@mail.gmail.com> <20070212140459.GA9679@linux-mips.org> <20070213.002545.03977174.anemo@mba.ocn.ne.jp> <20070213014345.GA30988@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.2i |
On Tue, Feb 13, 2007 at 01:43:45AM +0000, Ralf Baechle wrote:
> Well, I reverted that the old state of a warning is definately preferable
> until we found a proper solution.
Type-punning should do the trick.
Ralf
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/include/asm-mips/uaccess.h b/include/asm-mips/uaccess.h
index c12ebc5..36b3a42 100644
--- a/include/asm-mips/uaccess.h
+++ b/include/asm-mips/uaccess.h
@@ -265,7 +265,10 @@ do {
\
*/
#define __get_user_asm_ll32(val, addr) \
{ \
- unsigned long long __gu_tmp; \
+ union { \
+ unsigned long long l; \
+ __typeof__(*(addr)) t; \
+ } __gu_tmp; \
\
__asm__ __volatile__( \
"1: lw %1, (%3) \n" \
@@ -281,9 +284,10 @@ do {
\
" " __UA_ADDR " 1b, 4b \n" \
" " __UA_ADDR " 2b, 4b \n" \
" .previous \n" \
- : "=r" (__gu_err), "=&r" (__gu_tmp) \
+ : "=r" (__gu_err), "=&r" (__gu_tmp.l) \
: "0" (0), "r" (addr), "i" (-EFAULT)); \
- (val) = (__typeof__(*(addr))) __gu_tmp; \
+ \
+ (val) = __gu_tmp.t; \
}
/*
|
| Previous by Date: | Re: [PATCH] fix irq handling of DECstations, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH 2/3] signals: make common _BLOCKABLE macro, Ralf Baechle |
| Previous by Thread: | Re: [PATCH 3/3] signal.c: fix gcc warning on 32 bits kernel, Ralf Baechle |
| Next by Thread: | Re: [PATCH 3/3] signal.c: fix gcc warning on 32 bits kernel, Franck Bui-Huu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |